[fix][broker] fix can not cleanup heartbeat data if scaling down broker#22750
Merged
Technoboy- merged 1 commit intoapache:masterfrom May 30, 2024
Merged
Conversation
lhotari
reviewed
May 21, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
Outdated
Show resolved
Hide resolved
lhotari
requested changes
May 21, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
Outdated
Show resolved
Hide resolved
TakaHiR07
force-pushed
the
fix_cleanup_heartbeat_data_when_close_broker
branch
from
7a3e508 to
b4b5dc7
Compare
lhotari
reviewed
May 21, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
Outdated
Show resolved
Hide resolved
TakaHiR07
force-pushed
the
fix_cleanup_heartbeat_data_when_close_broker
branch
from
b4b5dc7 to
767090c
Compare
lhotari
reviewed
May 21, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
Outdated
Show resolved
Hide resolved
TakaHiR07
force-pushed
the
fix_cleanup_heartbeat_data_when_close_broker
branch
from
767090c to
20f3895
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22750 +/- ##
============================================
- Coverage 73.57% 70.97% -2.60%
+ Complexity 32624 4229 -28395
============================================
Files 1877 1891 +14
Lines 139502 148710 +9208
Branches 15299 16554 +1255
============================================
+ Hits 102638 105548 +2910
- Misses 28908 34959 +6051
- Partials 7956 8203 +247
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
approved these changes
May 30, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…er (apache#22750) Co-authored-by: fanjianye <fanjianye@bigo.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Issue: #21324
Motivation
Fix can not cleanup heartbeat data if scaling down broker
Modifications
when close the broker, delete heartbeat resource.
If the broker restart, the heartbeat resource would be recreate.
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: TakaHiR07#21